Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Clean components versions #3220

Conversation

robertomonteromiguel
Copy link
Collaborator

Motivation

There are some characters in the components versions, that may impact on the FP reports. Clean the string

Changes

Clean component version string

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@robertomonteromiguel robertomonteromiguel marked this pull request as ready for review October 10, 2024 20:33
@robertomonteromiguel robertomonteromiguel requested a review from a team as a code owner October 10, 2024 20:33
@robertomonteromiguel robertomonteromiguel merged commit 5ef769c into main Oct 10, 2024
289 of 292 checks passed
@robertomonteromiguel robertomonteromiguel deleted the robertomonteromiguel/onboarding_clean_components_versions branch October 10, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant